Commit 2dece4d9 authored by Sean Talts's avatar Sean Talts
Browse files

Fix mixed multivariate operands_and_partials

parent fcbcbb81
No related merge requests found
Showing with 6 additions and 6 deletions
+6 -6
......@@ -58,12 +58,13 @@ namespace stan {
Dx derivative(0);
for (size_t i = 0; i < this->operands_.size(); ++i) {
for (int j = 0; j < this->operands_[i].size(); ++j) {
derivative += this->partials_vec_[i](j) * this->operands_[i](j);
derivative += this->partials_vec_[i](j) * this->operands_[i](j).d_;
}
}
return derivative;
}
};
}
}
}
} // namespace detail
} // namespace math
} // namespace stan
#endif
......@@ -66,7 +66,6 @@ TEST(AgradPartialsVari, OperandsAndPartialsMultiMix) {
scalar(val_dxs[2], 0.0), scalar(val_dxs[3], 0.0);
uni_mat m2(2, 2);
// Set d_ to 1 for one variable we care about;
m1 << scalar(val_dxs[3], 1.0), scalar(val_dxs[2], 0.0),
scalar(val_dxs[1], 0.0), scalar(val_dxs[0], 0.0);
......@@ -100,7 +99,7 @@ TEST(AgradPartialsVari, OperandsAndPartialsMultiMix) {
EXPECT_FLOAT_EQ(0.0, grad_grad[1]);
EXPECT_FLOAT_EQ(0.0, grad_grad[2]);
EXPECT_FLOAT_EQ(0.0, grad_grad[3]);
EXPECT_FLOAT_EQ(1.0, grad_grad[4]);
EXPECT_FLOAT_EQ(0.0, grad_grad[4]);
EXPECT_FLOAT_EQ(0.0, grad_grad[5]);
EXPECT_FLOAT_EQ(0.0, grad_grad[6]);
EXPECT_FLOAT_EQ(0.0, grad_grad[7]);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment